[FFmpeg-devel] [PATCH] Indeo5 decoder
Maxim
max_pole
Mon Apr 13 12:54:33 CEST 2009
Diego Biurrun schrieb:
> On Mon, Apr 06, 2009 at 08:41:57PM +0200, Maxim wrote:
>
>> An updated patch attached fixing the most things showed by patcheck...
>>
>
> Documentation, build system and similar parts are now OK.
>
> Note that this patch is huge. Maybe you can find a way to split it,
> that would speed up reviewing. One way could be submitting the common
> code separately first.
>
Thanks, the inverse transform and the motion compensation will be placed
in separate files...
>
>> + if (!p) {
>> + band->quant_mat = (i > 1) ? i+1 : 0;
>> + } else {
>> + band->quant_mat = 5;
>> + }
>>
>
> redundant {}
>
Ok, I just want to clarify that case:
I corrected this statement after the patcheck showed me at that and some
other places the following message:
missing } prior to else
I noticed that both "if" and "else" statements contain only one line
therefore I made it conform to the "fully bracketed syntax" where both
parts are enclosed in brackets. How should I act in such cases: "ignore"
the patcheck's comments or use the "fully bracketed syntax"?
Regards
Maxim
More information about the ffmpeg-devel
mailing list