[FFmpeg-devel] [PATCH] RTP/Vorbis payload implementation (GSoC qual task)

Michael Niedermayer michaelni
Sun Apr 12 18:15:37 CEST 2009


On Sun, Apr 12, 2009 at 04:03:30PM +0200, Luca Barbato wrote:
> Ronald S. Bultje wrote:
>> Hi,
>> On Sun, Apr 12, 2009 at 6:14 AM, Luca Barbato <lu_zero at gentoo.org> wrote:
>>> +static int read_base128(uint8_t ** buf, uint8_t * buf_end)
>> [..]
>>> You should use the implementation that's already present in ffmpeg.
>> That's base64, not base128. We might want this one also as common code
>> if it's reused in other places (theora comes to mind).
>
> check ff_get_v it should be the same.

they differ by ByteIOContext vs. uint8_t*, as colin already noticed
it surely could still be used but iam not so sure if the result would
be any better.

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Avoid a single point of failure, be that a person or equipment.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090412/3597776c/attachment.pgp>



More information about the ffmpeg-devel mailing list