[FFmpeg-devel] [PATCH] QCELP decoder postfilter & final gain control

[Måns Rullgård]

"Reynaldo H. Verdejo Pinochet" <reynaldo at opendot.cl> writes:

> Hello
>
> Kenan Gillet wrote:
>> Hi Reynaldo,
>> On Apr 10, 2009, at 10:23 AM, Reynaldo H. Verdejo Pinochet wrote:
>> 
>>> Hello Kenan
>>>
>>> Kenan Gillet wrote:
>>>> +    // These two lines are to avoid a -1 subtraction in the main loop
>>>> +    filter_length++;
>>>> +    filter_coeffs--;
>>>
>>> That doesn't look right.
>> 
>> it is a little trick t avoid a -1 in the loop. It is taken straight from
>> the ff_celp_lp_synthesis_filterf
>
> Yup, I understand the why and I know its used elsewhere, I wasn't liking
> the how but after a talk with Baptiste I realized I was just being
> too picky. I'm applying this tomorrow after the chocolate eggs ;)

If filter_coeffs is pointing to the first element of an array, that
subtraction *is* invalid.

-- 
M?ns Rullg?rd
mans at mansr.com