[FFmpeg-devel] [PATCH] Document ff_put_string()

[Michael Niedermayer]

On Sat, Apr 11, 2009 at 03:57:37PM +0200, Diego Biurrun wrote:
> On Sat, Apr 11, 2009 at 03:53:48PM +0200, Stefano Sabatini wrote:
> > On date Saturday 2009-04-11 15:45:58 +0200, Diego Biurrun encoded:
> > > On Sat, Apr 11, 2009 at 03:37:57PM +0200, Stefano Sabatini wrote:
> > > > --- ffmpeg.orig/libavcodec/bitstream.h	2009-04-11 15:19:16.000000000 +0200
> > > > +++ ffmpeg/libavcodec/bitstream.h	2009-04-11 15:32:50.000000000 +0200
> > > > @@ -160,6 +160,13 @@
> > > > +
> > > > +/**
> > > > + * Puts the string \p s in the bitstream.
> > > > + *
> > > > + * @param put_zero if it is different from zero puts in the bitstream
> > > > + * a '\0' char just after the end of the string
> > > 
> > > This sentence has the problem I described earlier today.
> > 
> > Fixed.
> > --- ffmpeg.orig/libavcodec/bitstream.h	2009-04-11 15:45:50.000000000 +0200
> > +++ ffmpeg/libavcodec/bitstream.h	2009-04-11 15:53:03.000000000 +0200
> > @@ -159,6 +159,13 @@
> > +
> > +/**
> > + * Puts the string \p s in the bitstream.
> > + *
> > + * @param put_zero if it is different from zero puts a '\0' char in
> > + * the bitstream just after the end of the string
> 
> '\0'-terminate the string if value is non-zero

iam still unhappy
what about

0-terminate the written string if set


> 
> put_zero is not a very good name.

yes, that too

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Old school: Use the lowest level language in which you can solve the problem
            conveniently.
New school: Use the highest level language in which the latest supercomputer
            can solve the problem without the user falling asleep waiting.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090411/ce4be432/attachment.pgp>