[FFmpeg-devel] maintainer duties (was: Re: [PATCH] fix speex sample)

[Michael Niedermayer]

On Sat, Apr 11, 2009 at 01:14:29PM +0200, Diego Biurrun wrote:
> On Sat, Apr 11, 2009 at 05:48:07AM +0200, Michael Niedermayer wrote:
> > On Sat, Apr 11, 2009 at 03:42:04AM +0200, Diego Biurrun wrote:
> > > On Fri, Apr 10, 2009 at 10:48:36PM +0200, Michael Niedermayer wrote:
> > > > On Fri, Apr 10, 2009 at 09:01:36PM +0200, Diego Biurrun wrote:
> > > > > On Fri, Apr 10, 2009 at 08:45:41PM +0200, Michael Niedermayer wrote:
> > > > > > 
> > > > > > Was there a function i deprecated but did not replace where a trivial
> > > > > > search and replace was sufficient?
> > > > > 
> > > > > Did any of them require considerable amounts of work?  I don't think so.
> > > > 
> > > > let me repeat my question, what are you talking about?
> > > > Its very obvious you dont want the issues (if they even exist) fixed
> > > > because otherwise you would have pointed to them by now
> > > 
> > > I have already pointed the functions out:
> > > 
> > > http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/2009-March/065629.html
> > 
> > but this is what i meant, its either things that have alraedy been fixed
> > or things that are non trivial to fix.
> > you said above
> > "Did any of them require considerable amounts of work?  I don't think so."
> > 
> > Whats left from this list needs considerable amounts of work
> > 
> > lets see whats in that list:
> > 
> > > Michael:
> > > libavformat/asfdec.c:364: warning: AVPaletteControl is deprecated
> > > libavformat/avidec.c:491: warning: AVPaletteControl is deprecated
> > 
> > we first need to decide how to put the palette info into the bitstream, also
> > fixing these 2 will require all decoders that support palettes from avi/asf
> > to be fixed at the same time as well.
> 
> If this has not been decided, why is the function deprecated?  There
> should be a proper replacement first...

It has been decided to put the palette in the AVPackets
how to do this is a question per decoder and per demuxer, some may have a
natural way to pass the palette, some might even say in a spec how to do it
(though i guess that would be the exception if it applies to any at all)
the rest could just have a 'P'<len> vs. 'D' prefixed to packets

Besides AVPaletteControl in broken, it is not thread safe and does not work
in threaded players (ffplay being an example)
The deprecation of it just makes it nicely vissible that the code is broken
not deprecating it will just hide the bugs


> 
> > > libavutil/random.h:55: warning: av_random_generate_untempered_numbers is deprecated (declared at libavutil/random.h:39)
> > > libavutil/random.h:73: warning: av_random is deprecated (declared at libavutil/random.h:50)
> > > libavutil/random.h:55: warning: av_random_generate_untempered_numbers is deprecated (declared at libavutil/random.h:39)
> > > libavutil/random.h:73: warning: av_random is deprecated (declared at libavutil/random.h:50)
> > 
> > these have been fixed already, and iam sorry that i did not do more
> > of these fixes myself, but i dont really remember anyone asking me to
> > and what you putted under my name was nonsense not fixable, as the whole
> > file should and was removed once it became unused.
> > You did not list the actual uses of av_random() that occured all over the
> > place under my name ...
> 
> av_random() is now history thanks to my efforts.

and mine to actually write an alternative


> 
> > > Remaining deprecated functions are AVPaletteControl and ff_realloc_static,
> > > the latter is only used once even...
> > 
> > its used just once but to fix this each use of init_vlc() has to be changed
> > and in some cases in non trivial ways
> > I fixed some of these init_vlc cases, i did not fix all.
> > I was hoping the respective maintainers of the files would help ...
> 
> Why did you not request the maintainers to fix their code?

IIRC, i did


[...]
> > So next time you accuse me (and i am sure you will because it seems to be
> > poplar and the more polite i awnser the more people do)
> > maybe you should read and understand the code over which it is first.
> 
> What I want you to do is give proper attention to these matters and not
> leave them half-done.  When a function is deprecated, whomever creates
> the replacement should fix up the deprecated uses or coordinate efforts
> to get those uses replaced by maintainers or kindred spirits.

iam pestering mike since years to fix AVPaletteControl in his decoders


> 
> Note that I managed to do it for rand() and friends, _t POSIX namespace
> pollution and a few more things, so it's not like I do not put effort
> into these issues.

_t an rand() where easy search and replaces, whats left needs more effort
Ill look into these that fall into code i maintain of course

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If you really think that XML is the answer, then you definitly missunderstood
the question -- Attila Kinali
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090411/9f78a902/attachment.pgp>