[FFmpeg-devel] [PATCH] lzo build system checks

Diego Biurrun diego
Thu Apr 9 15:58:29 CEST 2009


On Thu, Apr 09, 2009 at 03:20:34PM +0200, Reimar D?ffinger wrote:
> On Thu, Apr 09, 2009 at 02:58:05PM +0200, Reimar D?ffinger wrote:
> > On Thu, Apr 09, 2009 at 02:38:11PM +0200, Diego Biurrun wrote:
> > > Here is a patch to properly hook up the lzo test in our build system.
> > > Reimar, maybe you can comment whether or not the different lzo functions
> > > are still really needed...
> > 
> > Wtf? Why would you want to make the lzo test test the libzo
> > decompression that FFmpeg doesn't even use at all?
> > And no you may not remove the libzo support from the test program, it is
> > there to allow speed comparison.
> > Probably the issue you have is the include?
> > Then put it under
> > #if defined(LIBLZO) || defined(LIBLZO_UNSAFE)
> 
> That's admittedly nonsense.
> the lzo.c file indeed depends on liblzo, for compression.
> So the check should be for
> lzo1x_999_compress in lzo/lzo1x.h

OK, here is my next try..

Diego
-------------- next part --------------
A non-text attachment was scrubbed...
Name: lzo.diff
Type: text/x-diff
Size: 1970 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090409/23a060f8/attachment.diff>



More information about the ffmpeg-devel mailing list