[FFmpeg-devel] Google Summer of Code participation

[Michael Niedermayer]

On Tue, Apr 07, 2009 at 12:01:35PM -0400, Ronald S. Bultje wrote:
> Hi,
> 
> On Tue, Apr 7, 2009 at 10:15 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
> > On Tue, Apr 07, 2009 at 02:51:08PM +0200, Thilo Borgmann wrote:
> >> Ronald S. Bultje schrieb:
> >>> @@ -89,7 +92,9 @@ static int sp5x_decode_frame(AVCodecContext *avctx,
> >>> ? ? ?recoded[j++] = 0xD9;
> >>>
> >>> ? ? ?avctx->flags &= ~CODEC_FLAG_EMU_EDGE;
> >>> - ? ?i = ff_mjpeg_decode_frame(avctx, data, data_size, recoded, j);
> >>> + ? ?avpkt_recoded.data = recoded;
> >>> + ? ?avpkt_recoded.size = j;
> >>> + ? ?i = ff_mjpeg_decode_frame(avctx, data, data_size, &avpkt_recoded);
> >>>
> >>> ? ? ?av_free(recoded);
> >>>
> >>> That leaves some fields uninitialized, you should use av_init_packet()
> >>> here also.
> [..]
> >> OK, added the init function in revision 7.
> [..]
> > tabs
> 
> Well yeah, applied without that. Good work, Thilo! I'll apply your
> last patch (moving of av_packet_*() functions) after lunch.

you seem not to have noticed but that after lunch patch is a prerequestite
to this patch, your commit made lavc depend on lavf

also, the qualification tasks are to find out if the students can create
patches that pass review, not if there is someone who can fix it halfway
up before commit

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In a rich man's house there is no place to spit but his face.
-- Diogenes of Sinope
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090407/d044d669/attachment.pgp>