[FFmpeg-devel] [PATCH] Indeo5 decoder

Maxim max_pole
Sat Apr 4 00:09:29 CEST 2009


Michael Niedermayer schrieb:
> On Wed, Apr 01, 2009 at 01:50:45PM +0200, Maxim wrote:
>   
>> Michael Niedermayer schrieb:
>>     
>>> On Wed, Apr 01, 2009 at 02:43:04AM +0200, Maxim wrote:
>>>   
>>>       
>>>> Diego Biurrun schrieb:
>>>>     
>>>>         
>>>>> Have you checked this works standalone, i.e. there are no other
>>>>> dependencies?
>>>>>
>>>>> Try disabling all decoders and encoders and just enabling indeo5 please.
>>>>>   
>>>>>       
>>>>>           
>>>> Yes, it does...
>>>>
>>>> Attached is an updated patch that fixes all things you pointed to.
>>>> The following things were changed as well:
>>>> - the inverse transform contains algebraic simplifications showed by
>>>> Michael in his earlier post
>>>> - a step was added to the inverse transform that tests for col/rows
>>>> containing zero coeffs and sets the corresponding output to zero instead
>>>> of performing the inverse transform on zeroes
>>>> - simplifications of the motion compensation functions
>>>>
>>>> Please any further reviews (Michael?)
>>>>     
>>>>         
>>> [snip]
>>>   
>>>       
>>> Non static with no ff_/av_ prefix
>>> indeo5patch.txt:856:+AVCodec indeo5_decoder = {
>>>   
>>>       
>> I'm sorry, where should I add ff_/av_ prefix here?
>>     
>
> ff_indeo5_decoder
>   

I've changed "indeo5_decoder" to "ff_indeo5_decoder" and the
"REGISTER_DECODER (INDEO5, indeo5);" to "REGISTER_DECODER (INDEO5,
ff_indeo5);" but the gcc refuses to compile it for now and says that the
indeo5 decoder isn't declared. The configure script doesn't show it in
the list of the enabled decoders as well. This change compiles under an
earlier version of the ffmpeg though. What's wrong? Please help!

Regards
Maxim



More information about the ffmpeg-devel mailing list