[FFmpeg-devel] [PATCH] libavdevice: JACK demuxer

[Diego Biurrun]

On Thu, Apr 02, 2009 at 12:36:16PM +0200, Olivier Guilyardi wrote:
> Attached:
> - jack demuxer patch 0.14
> - av_fifo_space patch
> 
> --- configure	(revision 18313)
> +++ configure	(working copy)
> --- doc/general.texi	(revision 18313)
> +++ doc/general.texi	(working copy)

OK

> --- libavformat/Makefile	(revision 18313)
> +++ libavformat/Makefile	(working copy)
> @@ -243,6 +243,9 @@
>  
> +# libavdevice dependencies
> +OBJS-$(CONFIG_JACK_DEMUXER)              += timefilter.o

I have to keep asking: Why isn't timefilter.c in libavdevice to begin
with?

> --- libavdevice/jack_audio.c	(revision 0)
> +++ libavdevice/jack_audio.c	(revision 0)
> @@ -0,0 +1,327 @@
> +        for (j = 0; j < self->buffer_size; j++) {
> +            pkt_data[j * self->nports + i] = buffer[j];
> +        }

useless {}

> +        if (!self->client) {
> +            av_log(context, AV_LOG_ERROR, "Input error: JACK server is gone\n");
> +        }

ditto

Diego