[FFmpeg-devel] [PATCH] QCELP decoder

[Diego Biurrun]

On Mon, Sep 29, 2008 at 06:36:30PM -0700, Kenan Gillet wrote:
>
> Anyway, enough blabla and here is a patch for decoding QCELP based on
> the last commit in SOC (r2373).

Neat, this had been rusting in the SoC repo for far too long.  I'm glad
you are picking it up.

> --- libavcodec/qcelp.h	(revision 0)
> +++ libavcodec/qcelp.h	(revision 0)
> @@ -0,0 +1,37 @@
> +
> +/**
> + * @file qcelpdata.h
> + * QCELP decoder
> + * @author Reynaldo H. Verdejo Pinochet
> + */
> +
> +typedef enum
> +{
> +    BLANK = 0,
> +    RATE_OCTAVE,
> +    RATE_QUARTER,
> +    RATE_HALF,
> +    RATE_FULL,
> +    I_F_Q,          /*!< insufficient frame quality */
> +    RATE_UNKNOWN
> +} qcelp_packet_rate;

All header files should have multiple inclusion guards.

> Property changes on: libavcodec/qcelp.h
> ___________________________________________________________________
> Name: svn:keywords
>    + Id Author

Huh?

> --- libavcodec/qcelpdec.c	(revision 0)
> +++ libavcodec/qcelpdec.c	(revision 0)
> @@ -0,0 +1,860 @@
> + * @return 0 if everything goes well, -1 frame should be erased

if frame

> +static int apply_pitch_filters(QCELPContext *q,
> +                                     float *cdn_vector,
> +                                     float *ppf_vector) {

weird indentation

I updated the SoC repo, please get my changes from there merged into
your code, it should be fairly easy.

Diego