[FFmpeg-devel] [PATCH] vp3.c: Don't compile a debug loop

[David Conrad]

On Sep 29, 2008, at 9:18 PM, Mike Melanson wrote:

> Michael Niedermayer wrote:
>> On Mon, Sep 29, 2008 at 06:25:36PM -0400, David Conrad wrote:
>>> On Sep 29, 2008, at 6:09 PM, David Conrad wrote:
>>>
>>>> Hi,
>>>>
>>>> gcc 4.0.1 isn't smart enough to optimize out this loop when  
>>>> debug_idct is
>>>> defined to nothing. This forces the loop to not be compiled when  
>>>> it does
>>>> nothing, for an overall speedup of about 1%.
>>> Actually this is a little cleaner; the previous gave m and n unused
>>> warnings.
>>
>> why dont you just remove the debug stuff?
>>
>> does anyone (mike?) want to keep it?
>
> Nope; rip it out.

Patch attached (with small cosmetic patchs), as well as another to  
remove unused code that's been moved elsewhere.

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 01-vp3-unused-debug.txt
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080930/3d0c20ad/attachment.txt>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 02-vp3-keyframe-return.txt
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080930/3d0c20ad/attachment-0001.txt>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 03-vp3-reindent.txt
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080930/3d0c20ad/attachment-0002.txt>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 04-vp3-unused-code.txt
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080930/3d0c20ad/attachment-0003.txt>