[FFmpeg-devel] [PATCH] assdec: non monotone timestamps

Michael Niedermayer michaelni
Tue Sep 30 03:03:06 CEST 2008

On Sat, Sep 27, 2008 at 05:55:24PM +0200, Aurelien Jacobs wrote:
> Hi,
> When trying to stream copy the attached ASS file with the following command:
>   ffmpeg -i test.ass -scodec copy test2.ass
> I get some "error, non monotone timestamps". They are due to the fact that
> this file contains several events with the same pts (this is perfectly
> valid ASS). I guess that those events with equal pts should be packed in
> the same AVPacket (the same way all the macroblocks from a video frame are
> stored in a single packet).
> Attached patch just implement this.

I agree with this in principle but i think the merging code should be in a
This maybe could also be used by matroska, but note, iam not completely sure
here, one problem that has to be considered is that to return a packet the
parser needs to know that the next will have a different pts. This could
lead to unacceptable latency for matroska+avparser when there is some time
between subtitle packets. But maybe iam missing something ...

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080930/8747cd43/attachment.pgp>

More information about the ffmpeg-devel mailing list