[FFmpeg-devel] [Patch] fix mingw sys/select.h inclusion
Fri Sep 26 19:43:21 CEST 2008
Luca Abeni wrote:
> Hi Baptiste,
> Baptiste Coudurier wrote:
>> Andrew Voznytsa wrote:
>>> Hi all,
>>> Simple patch to make network code compilable - mingw does not have
>> Damn, I included it to fix Freebsd 5.5 compilation, now we have a
>> sys/select.h is POSIX 2001.
> It seems to me that including sys/select.h (or similar) directly in
> rtsp.c is an error. I think it should be included in network.h (that
> already provides the proper "#ifdefs". In this way, we can move all the
> OS dependent code in a single file.
I don't think so, if a file is using network but not using select() it
has not reason to include it IMHO.
Baptiste COUDURIER GnuPG Key Id: 0x5C1ABAAA
Smartjog USA Inc. http://www.smartjog.com
Key fingerprint 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
More information about the ffmpeg-devel