[FFmpeg-devel] [PATCH] RealAudio SIPR @16k decoder (4/4) demuxer

Benjamin Larsson banan
Wed Sep 24 16:51:06 CEST 2008


> Could you try the code with some damaged files? (created by tools/trasher or
> some other tool)

I ran:

zzuf -c -r0.001:0.02 -s0:10000 -F5 -D0.5 -T60 -S ./ffmpeg -- -y -i
intro.rm -acodec copy out.wav

(file from mphq)

And crashes started coming, none that I could relate to the extra code

av_log(s, AV_LOG_ERROR, "%s codec not supported in WAVE format\n",
 s->streams[0]->codec->codec->name); with s->streams[0]->codec->codec
being NULL

I removed the lookup and it ran better.
At s=85 it crashed on a division by zero, block_align was 0 cause of
sub_packet_size corruption. Added a check for nozero block_size at the
end of rm_read_audio_stream_info fixed it.

After that it ran along for a good while. Several errors where reported
but no crashes occurred. Attached is not a patch for inclusion but just
what I added to get it running without crashing.

> ill review the new patch soon.

Benjamin Larsson
-------------- next part --------------
A non-text attachment was scrubbed...
Name: rmzzuf.diff
Type: text/x-diff
Size: 6567 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080924/2e84afc3/attachment.diff>

More information about the ffmpeg-devel mailing list