[FFmpeg-devel] [PATCH] libx264: support for BUILD >= 63
Wed Sep 17 09:24:54 CEST 2008
On date Tuesday 2008-09-16 23:52:50 +0100, M?ns Rullg?rd encoded:
> Stefano Sabatini <stefano.sabatini-lala at poste.it> writes:
> > On date Tuesday 2008-09-16 11:28:56 +0200, Stefano Sabatini encoded:
> >> On date Tuesday 2008-09-16 09:24:40 +0100, M?ns Rullg?rd encoded:
> >> > Stefano Sabatini <stefano.sabatini-lala at poste.it> writes:
> > [...]
> >> > It's always been expected that uses should have a recent version of
> >> > libraries they build FFmpeg against. Testing every little thing would
> >> > become such a chore.
> >> We know which version we need, and a simple check in the configure
> >> should ensure that the user is compiling against it.
> >> > > And while we're at it we could assert(X264_BUILD == x264_build()) in
> >> > > the init code (assuming that function is implemented).
> >> >
> >> > It a little harsh with assert(), wouldn't you say? In fact, this
> >> > shouldn't be needed at all, assuming libx264 uses correct shared
> >> > library versioning.
> >> See my other mail in response to Dark Shikari, but I have not a strong
> >> opinion on this, the configure check may be sufficient.
> > Attached there is a first experiment with check_version.
> Rejected. It doesn't work if cross-compiling. It may have other
> faults too; I didn't check carefully. Besides, I don't think this
> check is necessary.
Would be a solution using pkg-config acceptable?
stefano at geppetto ~/s/ffmpeg> pkg-config 'x264 >= 0.63.x' --print-errors
Requested 'x264 >= 0.63.x' but version of x264 is 0.60.x
FFmpeg = Frenzy Foolish Meaningless Patchable Ecumenical Gospel
More information about the ffmpeg-devel