[FFmpeg-devel] Realmedia patch
Mon Sep 15 16:25:12 CEST 2008
Ronald S. Bultje wrote:
> Hi Luca,
> On Sat, Sep 13, 2008 at 11:08 AM, Luca Abeni <lucabe72 at email.it> wrote:
>> Why RTSPPacketType and packet_type? According to rfc2326, this is called
>> "transport". The thing called RTSPProtocol by libavformat is what rfc2326
>> calls "transport/profile/lower-transport".
>> It looks like your patch wants to split "transport" and "lower-transport"
>> in two different variables. If so, you should use the correct names and
>> types, and probably refactor the RTSP code a little bit before adding
>> other modifications (for example, having an "RTSP_PROTOCOL_RTP_UDP"
>> RTSPProtocol contraddicts this approach)
> Attached patch renames RTSPProtocol to RTSPLowerTransport and does the
> refactoring accordingly.
This looks ok (I hope I did not miss any detail, and I assume you tested
So, I'd say to wait the usual 2 or 3 days and to commit if noone disagrees.
More information about the ffmpeg-devel