[FFmpeg-devel] [PATCH] Fix g726 encoder
Fri Sep 12 16:41:41 CEST 2008
Michael Niedermayer wrote:
> On Fri, Sep 12, 2008 at 01:41:28PM +0200, Rafa?l Carr? wrote:
>> Benjamin Larsson wrote:
>>> Rafa?l Carr? wrote:
>>>> On Thu, 2008-09-04 at 12:51 +0200, Michael Niedermayer wrote:
>>>>> I suspect this needs a update to the regression test checksums too
>>>> Is that something you can do before commit, after applying the patch ?
>>> After you have patched run "make test". This will show a diff in the
>>> g726 regressions tests. Change the values so the reg tests doesn't fail.
>>> And submit that with your patch.
>> I attach the patch with regression tests diffs.
>> -stddev: 8364.40 PSNR: 17.87 bytes: 96936/ 1058444
>> +stddev: 8557.39 PSNR: 17.67 bytes: 95788/ 1058444
> why does quality worsen by this "fix" ?
I don't know, I tried lowering the frame size, since ffmpeg will encode
1 frame at a time with the old behaviour, but it's only worse.
Maybe you can tell why and fix the problem I pointed you to ?
More information about the ffmpeg-devel