[FFmpeg-devel] [PATCH] [Issue 632] AAC pulse data is applied incorrectly

Robert Swain robert.swain
Thu Sep 11 02:54:39 CEST 2008

2008/9/11 Alex Converse <alex.converse at gmail.com>:
> This patch is pretty straight forward if you look at the relevant
> section if 14496-3. Basically the pulse data should be applied to
> match the sign of the underlying spectral coefficient (counting zero
> as negative). While requantizing the spectral coefficient we must be
> sure to not divide by zero.

Indeed. It looks good to me, Michael?

I wonder how the original author of that bit of code missed the two
cases. Though in my copy of the spec, the true and false cases are
either side of a page break.

> Note: This does not fix all the problems with the stream in Issue 632;
> there is still some bitstream decoding issue and possibly a TNS issue.

Are you using any special tools to locate these issues or just
printf(), gdb and your brain? :) I'm appreciative of any helpful
debugging/analysis tools or techniques of which I may not know.


More information about the ffmpeg-devel mailing list