[FFmpeg-devel] [PATCH] AVPacket.display_duration

Michael Niedermayer michaelni
Tue Sep 9 04:07:29 CEST 2008

On Tue, Sep 09, 2008 at 01:56:29AM +0200, Aurelien Jacobs wrote:
> Michael Niedermayer wrote:
> > On Fri, Sep 05, 2008 at 05:35:13PM +0200, Aurelien Jacobs wrote:
> > > Hi,
> > > 
> > > For some subtitles track, each AVPacket must carry the display duration
> > > of the contained subtitle.
> > > The attached patch adds a dedicated AVPacket.display_duration field.
> > 
> > Iam not against this, but i would like to understand better for which cases
> > it is needed.
> > 
> > plain UTF-8 and ASCII ?
> Exactly.
> > If so does mov, avi, asf, ... support plain UTF-8 and ASCII ?
> I don't think so...
> > if yes how do they know the display_duration ?
> The fact that they can't store any display duration just prevent
> them from storing plain text subtitles. At least I think so.
> Another possibility would be to not support any kind of plain text
> subtitles at all in ffmpeg. Demuxers could convert them to SRT,
> which is basically plain text + timing information. But I'm still
> not sure if I really like this solution.

iam fine with adding display_duration to AVPacket, the only minor
dislike i have with this solution is that codecs with very small
packets might see a minor speedloss with added fields. But then
not adding needed fields is no solution, some other solution for
these small packet audio codecs has to be found if it turns out that
the AVPacket handling overhead matters.

So again iam ok with adding display_duration.

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I do not agree with what you have to say, but I'll defend to the death your
right to say it. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080909/f91b046e/attachment.pgp>

More information about the ffmpeg-devel mailing list