[FFmpeg-devel] [PATCH] Add four metadata tags to 3gp files

[Baptiste Coudurier]

Hi,

Horacio Sanson wrote:
> Japanese mobile phones (Au, Softbank and Docomo) display these four tags when 
> accessing 3gp and 3g2 files properties. Our content providers mandate we put 
> these on all media we distribute, specially copyright.

Humm I understand.

> I would like to ask how to support other languages in the text strings?? I 
> really need this to support Japanese characters so any tips on how to do this 
> are welcome...

You could set AVStream->language and use it.

> ------------------------------------------------------------------------
> 
> Index: libavformat/movenc.c
> ===================================================================
> --- libavformat/movenc.c	(??????????????? 15260)
> +++ libavformat/movenc.c	(???????????????)
> @@ -1315,13 +1315,17 @@
>          put_be32(pb, 0); /* size */
>          put_tag(pb, "udta");
>  
> -        if (mov->mode & MODE_3GP) {
> +        if (mov->mode & MODE_3GP || mov->mode & MODE_3G2) {

This is a different issue, and must be submited as a different patch,
can you confirm these metadata tags are allowed in 3g2 and quote the
specs ? Thanks.

>              mov_write_3gp_udta_tag(pb, s, "titl", s->title);
>              mov_write_3gp_udta_tag(pb, s, "auth", s->author);
>              mov_write_3gp_udta_tag(pb, s, "gnre", s->genre);
>              mov_write_3gp_udta_tag(pb, s, "dscp", s->comment);
>              mov_write_3gp_udta_tag(pb, s, "albm", s->album);
>              mov_write_3gp_udta_tag(pb, s, "yrrc", "nil");
> +            mov_write_string_tag(pb, "\251nam", s->title, 0);
> +            mov_write_string_tag(pb, "\251aut", s->author, 0);
> +            mov_write_string_tag(pb, "\251des", s->comment, 0);
> +            mov_write_string_tag(pb, "\251cpy", s->copyright, 0);

Are these standardized in 3gp ? I don't think so, 3gp uses differents
tags IIRC like coded. Doesn't your content providers support 3gp tags ?
I might be inclined to allow this if not...

In the mean time, muxer now writes copyright tag.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
Smartjog USA Inc.                                http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA