[FFmpeg-devel] Review request - ra288.{c,h} ra144.{c,h}

Vitor Sessak vitor1001
Mon Sep 8 20:56:22 CEST 2008


Michael Niedermayer wrote:
> On Fri, Sep 05, 2008 at 12:23:58AM +0200, Vitor Sessak wrote:
>> Vitor Sessak wrote:
>>> Hi,
>>> Those four files never passed a review. I've just finished cleaning them 
>>> up, so if anyone wants to review them (Michael already said he will), 
>>> now is time.
>> I think now they can go through another review cycle.
> ok ra144  reveiw below, i also think that this is my last ra144
> review pass, i dont think id find much more ...

Changed everything as suggested with the exception of the following:

>> static int interp(RA144Context *ractx, int16_t *out, int block_num,
>>                   int copyold, int energy)
> it is slightly ugly that the 2 input lpc coeff vectors are not passed as
> aruments but taken from the context though iam not sure if it would be a
> good idea to add 2 more arguments ...


More information about the ffmpeg-devel mailing list