[FFmpeg-devel] [PATCH] rmdec.c and lavc: add SIPRO codec

[Benjamin Larsson]

Ronald S. Bultje wrote:
> Hi,
>
> On Thu, Sep 4, 2008 at 8:36 AM, Benjamin Larsson <banan at ludd.ltu.se> wrote:
>   
>> Ronald S. Bultje wrote:
>>     
>>> On Thu, Sep 4, 2008 at 8:18 AM, Benjamin Larsson <banan at ludd.ltu.se> wrote:
>>>       
>>>> Ronald S. Bultje wrote:
>>>>         
>>>>> On Thu, Sep 4, 2008 at 6:26 AM, Vladimir Voroshilov <voroshil at gmail.com> wrote:
>>>>>           
>>>>>> Here is updated patchset for SIPR @16k for anybody interesting in it.
>>>>>> Note, it is not cleaned up and thus will not be commited (or even
>>>>>> reviewed) in nearest time.
>>>>>>
>>>>>>             
>>>>> cool, thanks!
>>>>>
>>>>> So, I tried it and it doesn't work. :-).
>>>>>           
>>> [..]
>>>       
>>>> Dump the rm file with mplayer and then try to play the file again. Might
>>>> work better.
>>>>         
>>> Nope, still silence. I do use the rmdec.c parsing packet code for
>>> Realmedia/RTSP, so "if it plays as a file, it should play as a network
>>> stream". Of course, that's not true because -stats doesn't crash on
>>> the local file, but anyway... Is there anything else I can try?
>>>
>>> Here's the stream information according to -stats:
>>>     Stream #0.0: Audio: sipr, 8000 Hz, mono, s16, 8 kb/s
>>>
>>>       
>> 8kb/s != 16kb/s. The decoder doesn't handle 3 of the 4 possible modes.
>> Try finding some other streams that are 16kb/s.
>>     
>
> Could you add a meaningful error in the decoder for that?
>
> TIA,
> Ronald
>   

Well when I wrote the initial code there was a check for it, I guess 
Vladimir didn't port/rewrote that code. But we'll get there when the 
decoder officially is submitted for review.

MvH
Benjamin Larsson