[FFmpeg-devel] [PATCH] Fix g726 encoder

Michael Niedermayer michaelni
Thu Sep 4 12:51:53 CEST 2008

On Thu, Sep 04, 2008 at 11:17:29AM +0200, Rafa?l Carr? wrote:
> The g726 encoder iterates over the output buffer instead of the provided
> samples.

> Use a big output buffer like VLC, and overwrite your memory as you see
> fit.

I dont see how any memory could be overwritten.
out of array reads yes, writes no

> To know the size of the input buffer, the minimal frame size (in samples
> per channel) is needed, but doesn't exist in the code.
> I just use the same size that the reference code: 256 samples (32 ms)

I suspect this needs a update to the regression test checksums too

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I do not agree with what you have to say, but I'll defend to the death your
right to say it. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080904/9b289f90/attachment.pgp>

More information about the ffmpeg-devel mailing list