[FFmpeg-devel] WMA regression still broken / decouple regression rules

Michael Niedermayer michaelni
Tue Sep 2 22:25:33 CEST 2008

On Tue, Sep 02, 2008 at 07:11:48PM +0200, Benjamin Larsson wrote:
> Michael Niedermayer wrote:
> >> IIRC the last working version on x86-64 was r14756.
> >> And I think this is the last version which worked with all arch/compiler.
> >> r14757 which broke regtests is:
> >>   Change wma.c to use the ff_sine_window_init() from mdct.c
> >>     
> >
> > and does reverting it fix it again ? if so lets revert it!
> >   
> I think the combination of a new way to calculate the sine windows and 
> the new fft trigger the changes. I think the suggestion with a fixed 
> point mdct would result in a quite numerically stable mdct transform. 
> One could use the fixed point mdct in the ac3 encoder to do this.

iam ok with that too if someone does do it in a reasonale timeframe
The regression tests are important and should not be broken.
Reverting is easy writing new code may not be ...

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is dangerous to be right in matters on which the established authorities
are wrong. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080902/3f4de3e1/attachment.pgp>

More information about the ffmpeg-devel mailing list