[FFmpeg-devel] [PATCH] Fixed NULL deference in mov muxer

[Michael Niedermayer]

On Tue, Sep 02, 2008 at 09:08:49PM +0200, Reimar D?ffinger wrote:
> On Tue, Sep 02, 2008 at 08:36:21PM +0200, Laurent Aimar wrote:
> > On Tue, Sep 02, 2008, Baptiste Coudurier wrote:
> > > Laurent Aimar wrote:
> > > > The attached patch fixed a NULL deference in mov muxer for unsupported
> > > > track.
> > > Interesting, what do you mean by unsupported ?
> > > Are you creating a track with no samples ?
> > 
> > Sorry, I didn't meant to send this one, I do not think a fix is needed at all
> > here.
> > 
> > About my problem:
> > 
> > track->enc was NULL because mov_write_header had failed but I still called
> > mov_write_trailer.
> > 
> > It is not documented how to react to av_write_header erros but it seems
> > logical that I should not call av_write_trailer if av_write_header has
> > failed...
> 

> Maybe this should be done:

ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

While the State exists there can be no freedom; when there is freedom there
will be no State. -- Vladimir Lenin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080902/08273e02/attachment.pgp>