[FFmpeg-devel] Realmedia patch

[Ronald S. Bultje]

Hi Luca & all,

On Mon, Sep 1, 2008 at 3:12 PM, Luca Abeni <lucabe72 at email.it> wrote:
> Ronald S. Bultje wrote:
> [...]
>>>> +    if (!(rt->server_type == RTSP_SERVER_RDT && rt->need_subscription)) {
>>> This change looks suspicious...
>>> (same for the rtsp_read_pause() change)
>>
>> These two can (hopefully) be addressed in one...
>>
>> So, for Realmedia, you can subscribe to one of the N rules. The way
>> ffplay does that is that it calls av_open_input_file() and
>> av_find_stream_info(), then chooses one of the N streams (based on the
>> -ast X parameter) and then it sets the AVDISCARD_* flag in all
>> AVStreams and starts reading data.
> [...]
>
> Thanks for the explaination. As usual, I forgot about stream selection ;-)
>
>> I modified rtsp_play() (and pause()) to not be sent while the
>> Subscribe command hasn't been sent yet, that's the second half of this
>> change. Ugly, I know, but it worked. :-]. I'm open for suggestions on
>> how to better do this.
>
> I understand this is a drastic change in the existing code, so I'd say
> to go for it only if the maintainer explicitly agrees (otherwise, I see
> no alternatives to your approach).

So, since LucaB is not really responding, I'll apply this one in 2-3
days unless somebody objects.

Ronald