[FFmpeg-devel] Visibility implementation

[Diego Biurrun]

On Tue, Oct 28, 2008 at 04:59:24PM +0000, M?ns Rullg?rd wrote:
> 
> Diego Biurrun wrote:
> > On Fri, Oct 24, 2008 at 10:30:55AM +0200, Diego Biurrun wrote:
> >> On Thu, Oct 23, 2008 at 09:25:35PM +0100, M?ns Rullg?rd wrote:
> >> > Diego Biurrun <diego at biurrun.de> writes:
> >> > >
> >> > > Updated version attached.
> >> > >
> >> > > --- libavutil/internal.h	(revision 15672)
> >> > > +++ libavutil/internal.h	(working copy)
> >> > > @@ -50,6 +50,18 @@
> >> > >
> >> > > +#ifdef CONFIG_VISIBILITY
> >> >
> >> > Where do you expect this to get set?  Is there any reason to disable
> >> > it when the compiler supports it?  I would expect to see some compiler
> >> > version ifdeffery or a configure check setting HAVE_ATTR_VISIBILITY or
> >> > similar.
> >>
> >> ATM it would have to be set manually in config.h, i.e. configure support
> >> is still missing.  I'll see if I implement it in the next round.
> >
> > OK, here is the next version, along with configure support.  This should
> > be fit for committing.
> 
> I don't like --enable-visiblity.  Especially for something video-related
> its meaning is not at all clear.  Call it --enable-symbol-hiding or
> similar instead.

Done.

> You're still adding insane amounts of whitespace around the section
> start/stop lines.  Why?

Very well, here is a version without so much whitespace.

Diego
-------------- next part --------------
A non-text attachment was scrubbed...
Name: visibility.diff
Type: text/x-diff
Size: 42828 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20081031/05b2fef3/attachment.diff>