[FFmpeg-devel] Request for review

[Michael Niedermayer]

On Thu, Oct 30, 2008 at 09:12:54AM -0700, Roman V. Shaposhnik wrote:
> On Tue, 2008-10-28 at 19:06 +0100, Michael Niedermayer wrote:
> > > Yes indeed. Speaking of which -- do we plan to offer any kind of locking
> > > mechanism in libav* ?
> > 
> > no unless it is needed for the frame multithreading stuff ...
> 
> Fair enough. Given your nice suggestion on how to avoid races
> looks like we won't need it this time around.
> 
> Attached is an updated patch. Please let me know if it looks
> ok.
[...]
> @@ -6159,6 +6160,16 @@ static const uint8_t block_sizes_dv100[8] = {
>      80, 80, 80, 80, 80, 80, 64, 64,
>  };
>  
> +static void     *work_chunks_dv25pal[1*12*27];
> +static void  *work_chunks_dv25pal411[1*12*27];
> +static void    *work_chunks_dv25ntsc[1*10*27];
> +static void     *work_chunks_dv50pal[2*12*27];
> +static void    *work_chunks_dv50ntsc[2*10*27];
> +static void   *work_chunks_dv100palp[2*12*27];
> +static void  *work_chunks_dv100ntscp[2*10*27];
> +static void   *work_chunks_dv100pali[4*12*27];
> +static void  *work_chunks_dv100ntsci[4*10*27];
> +
>  static const DVprofile dv_profiles[] = {
>      { .dsf = 0,
>        .video_stype = 0x0,

now its reall nitpicking but

static void  *work_chunks_dv25pal   [1*12*27];
static void  *work_chunks_dv25pal411[1*12*27];
static void  *work_chunks_dv25ntsc  [1*10*27];
static void  *work_chunks_dv50pal   [2*12*27];
static void  *work_chunks_dv50ntsc  [2*10*27];
static void  *work_chunks_dv100palp [2*12*27];
static void  *work_chunks_dv100ntscp[2*10*27];
static void  *work_chunks_dv100pali [4*12*27];
static void  *work_chunks_dv100ntsci[4*10*27];

looks nicer IMHO

except that the patch is fine and no need to resubmit no matter what you
decide for above

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many that live deserve death. And some that die deserve life. Can you give
it to them? Then do not be too eager to deal out death in judgement. For
even the very wise cannot see all ends. -- Gandalf
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20081030/cb4dcafe/attachment.pgp>