[FFmpeg-devel] [PATCH] QCELP decoder

[Michael Niedermayer]

On Thu, Oct 30, 2008 at 03:26:05PM -0700, Kenan Gillet wrote:
>
> On Oct 30, 2008, at 3:11 PM, Michael Niedermayer wrote:
>
>> On Thu, Oct 30, 2008 at 02:50:45PM -0700, Kenan Gillet wrote:
>>> On Thu, Oct 30, 2008 at 2:31 PM, Diego Biurrun <diego at biurrun.de> wrote:
>>>> On Thu, Oct 30, 2008 at 10:07:45PM +0100, Vitor Sessak wrote:
>>>>> Michael Niedermayer wrote:
>>>>>>> --- libavcodec/celp_filters.h      (revision 15692)
>>>>>>> +++ libavcodec/celp_filters.h      (working copy)
>>>>>>> @@ -69,4 +69,28 @@
>>>>>>>
>>>>>>> +/**
>>>>>>> + * LP synthesis filter.
>>>>>>> + * @param out [out] pointer to output buffer
>>>>>>> + *        - the array out[-filter_length, -1] must
>>>>>>> + *        contain the previous result of this filter
>>>>>>> + * @param filter_coeffs filter coefficients.
>>>>>>> + * @param in input signal
>>>>>>> + * @param buffer_length amount of data to process
>>>>>>> + * @param filter_length filter length (10 for 10th order LP filter)
>>>>>>> + *
>>>>>>> + * @return 1 if overflow occurred, 0 - otherwise
>>>>>>
>>>>>> hmm void == 1 || 0 ?
>>>>>
>>>>> Oops, commited by error, should I revert?
>>>>
>>>> I'd say commit the fix when it appears, there is no point in reverting
>>>> (currently) unused code.
>>>
>>> is that fix ok?
>>
>>> Index: libavcodec/celp_filters.h
>>> ===================================================================
>>> --- libavcodec/celp_filters.h	(revision 15754)
>>> +++ libavcodec/celp_filters.h	(working copy)
>>> @@ -79,8 +79,6 @@
>>>  * @param buffer_length amount of data to process
>>>  * @param filter_length filter length (10 for 10th order LP filter)
>>>  *
>>> - * @return 1 if overflow occurred, 0 - otherwise
>>> - *
>>
>> ok but
>>
>>>  * @note Output buffer must contain 10 samples of past
>>>  *       speech data before pointer.
>>>  *
>>
>> 10 samples ? isnt it filter_length samples?
>
> yes, patch attached that fix doxy for ff_celp_lp_synthesis_filter and 
> ff_celp_lp_synthesis_filterf

ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Democracy is the form of government in which you can choose your dictator
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20081030/d5525802/attachment.pgp>