[FFmpeg-devel] [PATCH] QCELP decoder

[Kenan Gillet]

On Thu, Oct 30, 2008 at 2:31 PM, Diego Biurrun <diego at biurrun.de> wrote:
> On Thu, Oct 30, 2008 at 10:07:45PM +0100, Vitor Sessak wrote:
>> Michael Niedermayer wrote:
>> >> --- libavcodec/celp_filters.h      (revision 15692)
>> >> +++ libavcodec/celp_filters.h      (working copy)
>> >> @@ -69,4 +69,28 @@
>> >>
>> >> +/**
>> >> + * LP synthesis filter.
>> >> + * @param out [out] pointer to output buffer
>> >> + *        - the array out[-filter_length, -1] must
>> >> + *        contain the previous result of this filter
>> >> + * @param filter_coeffs filter coefficients.
>> >> + * @param in input signal
>> >> + * @param buffer_length amount of data to process
>> >> + * @param filter_length filter length (10 for 10th order LP filter)
>> >> + *
>> >> + * @return 1 if overflow occurred, 0 - otherwise
>> >
>> > hmm void == 1 || 0 ?
>>
>> Oops, commited by error, should I revert?
>
> I'd say commit the fix when it appears, there is no point in reverting
> (currently) unused code.

is that fix ok?
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: celp_filters-doxy-cleanup.patch.txt
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20081030/1aa641aa/attachment.txt>