[FFmpeg-devel] [PATCH] QCELP decoder

[Kenan Gillet]

On Oct 30, 2008, at 2:07 PM, Vitor Sessak wrote:

> Michael Niedermayer wrote:
>> On Tue, Oct 28, 2008 at 04:47:02PM -0700, Kenan Gillet wrote:
>>> On Tue, Oct 28, 2008 at 4:43 PM, Kenan Gillet <kenan.gillet at gmail.com 
>>> > wrote:
>>>> thanks Diego and Michael for your reviewing.
>>>>
>>>> And here is an updated set of patches with a few changes too.
>>>>
>>>> round 7 summary:
>>>> - qcelp-round7-doc-glue.patch.txt has already been oked
>>>> - grammar / spelling / cosmetics
>>>> - generalize convolve function used in qcelp_lspf2lpc
>>>> - remove some multiplication and division in compute_svector
>>>> - frame unpacking rework
>>>> - most of the previous comments
>>>>
>>

[..]


>>> Index: libavcodec/celp_filters.h
>>> ===================================================================
>>> --- libavcodec/celp_filters.h	(revision 15692)
>>> +++ libavcodec/celp_filters.h	(working copy)
>>> @@ -69,4 +69,28 @@
>>>         int stop_on_overflow,
>>>         int rounder);
>>>
>>> +/**
>>> + * LP synthesis filter.
>>> + * @param out [out] pointer to output buffer
>>> + *        - the array out[-filter_length, -1] must
>>> + *        contain the previous result of this filter
>>> + * @param filter_coeffs filter coefficients.
>>> + * @param in input signal
>>> + * @param buffer_length amount of data to process
>>> + * @param filter_length filter length (10 for 10th order LP filter)
>>> + *
>>> + * @return 1 if overflow occurred, 0 - otherwise
>>
>> hmm void == 1 || 0 ?
>
> Oops, commited by error, should I revert?

what about just removing the line ?

and thanks for commiting :)