[FFmpeg-devel] [PATCH] QCELP decoder

[Diego Biurrun]

On Thu, Oct 30, 2008 at 11:44:24AM -0700, Kenan Gillet wrote:
> 
> On Oct 30, 2008, at 6:21 AM, Michael Niedermayer wrote:
> 
> > On Thu, Oct 30, 2008 at 10:59:56AM +0100, Diego Biurrun wrote:
> >>> --- libavcodec/celp_math.c	(revision 15692)
> >>> +++ libavcodec/celp_math.c	(working copy)
> >>> @@ -195,3 +195,14 @@
> >>>
> >>> +    for(i=0; i<length; i++)
> >>
> >> Some more whitespace will earn you extra good karma here.
> >
> > i do like the whitespace in the for as it is. Though i agree the {
> > would look a little nicer in the same line as for.
> > </bikeshed>
> 
> I have no strong opinion on this, I just tried to stay consistent with  
> the code in the celp_*.[ch]
> Let me know what you would prefer.

You formatted it as 

    for(i = 0; i < length; i++)

in other places, so you should be consistent.  And yes, I find the
latter version more readable.

Diego