[FFmpeg-devel] [PATCH] QCELP decoder

[Michael Niedermayer]

On Thu, Oct 30, 2008 at 10:59:56AM +0100, Diego Biurrun wrote:
[...]
> > --- libavcodec/celp_filters.c	(revision 15692)
> > +++ libavcodec/celp_filters.c	(working copy)
> > @@ -84,3 +84,24 @@
> >  
> > +    for(n=0; n<buffer_length; n++)
> > +    {
> 
> You put the opening brace on the same line in other places.  And the for
> expression could use some whitespace.
> 
> > +        out[n] = in[n];
> > +        for(i=1; i<filter_length; i++)
> 
> ditto
> 
> > --- libavcodec/celp_math.c	(revision 15692)
> > +++ libavcodec/celp_math.c	(working copy)
> > @@ -195,3 +195,14 @@
> >  
> > +    for(i=0; i<length; i++)
> 
> Some more whitespace will earn you extra good karma here.

i do like the whitespace in the for as it is. Though i agree the {
would look a little nicer in the same line as for.
</bikeshed>

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

He who knows, does not speak. He who speaks, does not know. -- Lao Tsu
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20081030/6aa2c77b/attachment.pgp>