[FFmpeg-devel] [PATCH] Remove unnecessary calls to show_help()

Diego Biurrun diego
Thu Oct 30 00:11:56 CET 2008


On Wed, Oct 29, 2008 at 11:55:22PM +0100, Stefano Sabatini wrote:
> On date Wednesday 2008-10-29 00:03:17 +0100, Diego Biurrun encoded:
> > On Tue, Oct 28, 2008 at 09:15:16PM +0100, Stefano Sabatini wrote:
> > > 
> > > --- ffplay.c	(revision 15731)
> > > +++ ffplay.c	(working copy)
> > > @@ -2553,7 +2553,7 @@
> > >      if (!input_filename) {
> > > -        show_help();
> > > +        fprintf(stderr, "Must supply at least one input file\n");
> > 
> > You must supply at least one input file.
> 
> So I suppose also the ffmpeg.c messages has to be fixed, also since
> ffplay only take one input file I changed the message accordingly.
> 
> Check the patch below, and yes the ffmpeg.c messages fix would go in a
> separate commit.

You missed the period on all occasions.

Diego




More information about the ffmpeg-devel mailing list