[FFmpeg-devel] [PATCH] av_picture_copy misses pixels on packed planar AVPictures with odd width or height

Michael Niedermayer michaelni
Wed Oct 29 22:01:14 CET 2008

On Wed, Oct 29, 2008 at 12:15:28PM -0700, Art Clarke wrote:
> On Wed, Oct 29, 2008 at 9:38 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
> >> 1) Create a AVPicture with an odd width and height (e.g. 503w x 251h)
> >> in a packed pixel format (e.g. YUV_420P).
> >
> > P stands for planar
> Yeah... realized I mistyped packed after I sent that.
> > width= -((-width)>>pf->x_chroma_shift);
> See attached diff.  By the way, if you care about the original code I
> used, I snagged it from the much hotter (usually) ff_fill_* methods.
> I'm not going to patch those methods because the old code does the
> right thing, just not as elegantly.
> > this seems to contain an unrelated change
> Yup, it was removing an unused variable (as I documented).  New patch
> now no longer removes that variable, but also doesn't fix the
> incorrect calculation the unused variable does.

patch looks ok
also a seperate patch removing the unused var is welcome ...

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No snowflake in an avalanche ever feels responsible. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20081029/c20e6d1d/attachment.pgp>

More information about the ffmpeg-devel mailing list