[FFmpeg-devel] [PATCH] Avisynth seeking out of sync

[Michael Niedermayer]

On Sat, Oct 25, 2008 at 02:34:51AM +0200, arnaud.brochard at free.fr wrote:
> Sorry, forgot to join the file :p
> 
> Selon arnaud.brochard at free.fr:
> 
> > Hi, I found an out of sync problem with the seeking option (-ss) on an
> > AviSynth
> > (avs) input file: the more far is the video seeking position, the larger is
> > the
> > out of sync.
> > So I checked out the code and found that a variable (chunk_samples) was of
> > long
> > type and badly rounded by calculations, which led to the problem. I solved it
> > with a change of type to float, and a division operation with no rounding.

floats are unacceptable and practically always wrong, also floats do rounding
as well.
A solution has to be exact.
Besides we need a reproduceable test case or a quote from a spec that confirms
that the change is correct. (and better both)

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many that live deserve death. And some that die deserve life. Can you give
it to them? Then do not be too eager to deal out death in judgement. For
even the very wise cannot see all ends. -- Gandalf
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20081025/ee8606c7/attachment.pgp>