[FFmpeg-devel] [PATCH] Fix fft_mmx dependency in Makefile

Måns Rullgård mans
Sat Oct 25 01:22:02 CEST 2008


David DeHaven <dave at sagetv.com> writes:

>>>> Index: libavcodec/Makefile
>>>> ===================================================================
>>>> --- libavcodec/Makefile	(revision 15670)
>>>> +++ libavcodec/Makefile	(working copy)
>>>> @@ -392,12 +392,15 @@
>>>>        i386/idct_mmx_xvid.o \
>>>>        i386/idct_sse2_xvid.o \
>>>>
>>>> +ifeq (fft.o, $(findstring "fft.o" , $(OBJS-yes)))
>>>> OBJS-$(HAVE_YASM)                      += i386/fft_mmx.o \
>>>>                                          i386/fft_sse.o \
>>>>                                          i386/fft_3dn.o \
>>>>                                          i386/fft_3dn2.o \
>>>> -                                          i386/dsputil_yasm.o \
>>>>
>>>> +endif
>>>> +OBJS-$(HAVE_YASM)                      += i386/dsputil_yasm.o \
>>>
>>> This is not a proper solution.
>
> Bad me, left quotes in:
>
> +ifeq (fft.o, $(findstring fft.o, $(OBJS-yes)))
>
> Or were you hinting at something else?

Yes, I just committed a proper fix.  As a bonus, you can now disable
everything that uses FFT with --disable-fft (or force it on even if
nothing explicitly requires it).

-- 
M?ns Rullg?rd
mans at mansr.com




More information about the ffmpeg-devel mailing list