[FFmpeg-devel] [PATCH] QCELP decoder

Diego Biurrun diego
Fri Oct 24 23:08:33 CEST 2008


On Thu, Oct 23, 2008 at 10:27:29PM +0200, Michael Niedermayer wrote:
> On Thu, Oct 23, 2008 at 09:27:10PM +0200, Diego Biurrun wrote:
> > On Thu, Oct 23, 2008 at 12:22:42PM -0700, Kenan Gillet wrote:
> > > On Tue, Oct 21, 2008 at 3:34 PM, Diego Biurrun <diego at biurrun.de> wrote:
> > > > On Tue, Oct 21, 2008 at 03:19:36PM -0700, Kenan Gillet wrote:
> > > >> On Sat, Oct 18, 2008 at 1:28 AM, Diego Biurrun <diego at biurrun.de> wrote:
> > > >> > On Fri, Oct 17, 2008 at 05:16:05PM -0700, Kenan Gillet wrote:
> > > >> >>
> > > >> >> On Oct 17, 2008, at 3:44 PM, Diego Biurrun wrote:
> > > >> >>
> > > >> >> > On Fri, Oct 17, 2008 at 09:46:31AM -0700, Kenan Gillet wrote:
> > > >> >> >>
> > > >> >> >> round 6 summary:
> > > >> >> >> - no code change from round 5
> > > >> >> >> - replace svn cp by svn add to make the patch smaller
> > > >> >> >> - rename qcelp_math.[ch] into celp_math.[ch]
> > > >> >> >
> > > >> >> > Maybe we can rename some of the acelp_*.[ch] files to celp_*.[ch]
> > > >> >> >
> > > >> >> > already if it helps you.
> > > >> >>
> > > >> >> sure or i can just add the code in acelp_*.[ch].
> > > >> >> Either way is fine with me
> > > >>
> > > >> any opinion on this one?
> > > >
> > > > Send a patch that splits the files in HEAD into celp and acelp variants,
> > > > I will apply it right away.
> > > 
> > > The whole acelp_math.[ch] can be moved to celp_math.[ch] and then
> > > the patch rename-acelp_math-to-celp_math.patch.txt can be applied.
> > > 
> > > acelp_filters.[ch] needs to be svn copied.
> > > Then the patch split-acelp_filters.patch can be applied.
> > 
> > Michael, can I apply this?
> 
> i guess yes but, Iam no celp expert so some of these may need to me moved
> again in the future, i suspect some of them may even be usefull outside celp.

OK, we will have to move stuff around more then.  I will commit as soon
as compilation finishes.

Diego




More information about the ffmpeg-devel mailing list