[FFmpeg-devel] [PATCH] Fix fft_mmx dependency in Makefile

[Måns Rullgård]

David DeHaven <dave at sagetv.com> writes:

> If yasm is detected, libavcodec/i386/fft_mmx.asm is appended to OBJS-
> yes without consideration of whether libavcodec/fft.c is being
> compiled and the build fails due to missing dependencies in fft.c.
> This patch fixes that problem.
>
> -DrD-
>
> Index: libavcodec/Makefile
> ===================================================================
> --- libavcodec/Makefile	(revision 15670)
> +++ libavcodec/Makefile	(working copy)
> @@ -392,12 +392,15 @@
>          i386/idct_mmx_xvid.o \
>          i386/idct_sse2_xvid.o \
>  
> +ifeq (fft.o, $(findstring "fft.o" , $(OBJS-yes)))
>  OBJS-$(HAVE_YASM)                      += i386/fft_mmx.o \
>                                            i386/fft_sse.o \
>                                            i386/fft_3dn.o \
>                                            i386/fft_3dn2.o \
> -                                          i386/dsputil_yasm.o \
>  
> +endif
> +OBJS-$(HAVE_YASM)                      += i386/dsputil_yasm.o \

This is not a proper solution.

-- 
M?ns Rullg?rd
mans at mansr.com