[FFmpeg-devel] [RFC UNTESTED PATCH] Add IA-64 assembly byteswapping functions.

Måns Rullgård mans
Fri Oct 24 02:52:13 CEST 2008


"Eli Friedman" <eli.friedman at gmail.com> writes:

> On Thu, Oct 23, 2008 at 12:37 AM, Diego Biurrun <diego at biurrun.de> wrote:
>>> +static av_always_inline av_const uint16_t bswap_16(uint16_t x)
>>> +{
>>> +    uint16_t __v;
>>
>> This is an illegal variable name, names starting with __ are reserved
>> for the system.  Please educate the glib guys about this.
>
> This code is originally from the system header byteswap.h.

But it's not there now.

> glibc can't use any unreserved identifiers there because they could
> be redefined.

While this is true, the origin of the code has no relevance whatsoever
to the symbol names it may use if copied somewhere else.

-- 
M?ns Rullg?rd
mans at mansr.com




More information about the ffmpeg-devel mailing list