[FFmpeg-devel] PATCH Fix SSE core-dumps when decoding AAC on optimized ffmpeg with shared libraries compiled under Mingw (win32)

[Art Clarke]

On Wed, Oct 22, 2008 at 11:55 AM, Art Clarke <aclarke at vlideshow.com> wrote:
> On Wed, Oct 22, 2008 at 11:33 AM, Ramiro Polla <ramiro.polla at gmail.com> wrote:
>> On Wed, Oct 22, 2008 at 4:27 PM, Art Clarke <aclarke at vlideshow.com> wrote:
>>> Hi folks,
>>>
>>> Attached is a patch that fixes a bug where ACC decoding fails with the
>>> new decoder.  To reproduce, build ffmpeg in SHARED library mode on
>>> Mingw with the latest runtime and win32 library, with all
>>> optimizations turned on, and then try to decode an aac file on a
>>> machine with the SSE2 instruction set available (how's that for
>>> esoteric).
>>>
>>> ffmpeg -i aacfile.aac -acodec pcm_mulaw -y out.wav
>>>
>>> The problem is that the GCC compiler on mingw doesn't correctly align
>>> uninitialized local variables in mingw.  This causes some of the SSE
>>> optimizations under the new AAC decoder to work on non-64-bit aligned
>>> local variables and badness occurs.
>>>
>>> The fix is to pass "-fno-common" to the GCC compiler under mingw if
>>> mmx2 is enabled.  This allows assembly that tries to align
>>> uninitialized local variables on 64 bit boundaries at the cost of not
>>> allowing you to define an uninitialized variable with extern linkage
>>> more than once (without specifying at all but one instances as extern
>>> -- something ffmpeg already enforces)*.
>>>
>>> Major major kudos to Gianluigi Tiesi for figuring this out with the
>>> GCC team.  He's been working on getting mplayer to compile on Mingw.
>>>
>>> See here for the details on the GCC bug and "-fno-common" workaround:
>>> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37216
>>
>> ./configure --extra-cflags="-fno-common"
>>
>> and you're done...
>>
>> Your patch will do more harm than good once gcc/binutils are fixed on MinGW.
>>
>> Still, thanks for Gianluigi Tiese for finding that out.
>>
>> Ramiro Polla
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel at mplayerhq.hu
>> https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel
>>
>
> Although I'm actually pretty sure the attached fix is safe, I
> understand your concern.  Can I least convince you to accept the
> following patch to save folks the 3 days of pain we just went through?
>
> - Art
>

Apologies, but the last time my fix wasn't attached for some reason.
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: diff.txt
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20081022/73baafc4/attachment.txt>