[FFmpeg-devel] [PATCH] Use pkgconfig for dirac libs

[Diego Biurrun]

On Wed, Oct 22, 2008 at 04:35:16PM +0200, Chris Hills wrote:
> On 22/10/08 07:29, Diego Biurrun wrote:
> > Absolutely not, using pkg-config at all is a workaround for libdirac's
> > horrid include path design.  They have 3 directories for 5 header files.
> > Unfortunately the fact that nobody else does this did not tell them
> > anything...
> 
> That was perhaps true older versions, but pkg-config --cflags with dirac 
> 1.0.0 gives the following output for me (and ffmpeg compiles fine):-
> 
> -I/home/chaz/Libraries/libdirac/1.0.0/include/dirac

So you do not have the following nonsense in /usr/local/include:


diego at cerebus:~$ ls -RF /usr/local/include/dirac/
/usr/local/include/dirac/:
libdirac_common/  libdirac_decoder/  libdirac_encoder/

/usr/local/include/dirac/libdirac_common:
common_types.h  dirac_types.h

/usr/local/include/dirac/libdirac_decoder:
decoder_types.h  dirac_parser.h

/usr/local/include/dirac/libdirac_encoder:
dirac_encoder.h


?

> So I think either use pkg-config for both cflags and libs, or remove it 
> altogether. Using it for just one or the other is inconsistent.

We consistently use the least amount of pkg-config calls that is
possible.

Diego