[FFmpeg-devel] [PATCH] QCELP decoder

[Kenan Gillet]

Hi,
On Sat, Oct 18, 2008 at 1:28 AM, Diego Biurrun <diego at biurrun.de> wrote:
> On Fri, Oct 17, 2008 at 05:16:05PM -0700, Kenan Gillet wrote:
>>
>> On Oct 17, 2008, at 3:44 PM, Diego Biurrun wrote:
>>
>> > On Fri, Oct 17, 2008 at 09:46:31AM -0700, Kenan Gillet wrote:
>> >>
>> >> round 6 summary:
>> >> - no code change from round 5
>> >> - replace svn cp by svn add to make the patch smaller
>> >> - rename qcelp_math.[ch] into celp_math.[ch]
>> >
>> > Maybe we can rename some of the acelp_*.[ch] files to celp_*.[ch]
>> >
>> > already if it helps you.
>>
>> sure or i can just add the code in acelp_*.[ch].
>> Either way is fine with me

any opinion on this one?


>> >> --- libavcodec/qcelpdata.h (revision 0)
>> >> +++ libavcodec/qcelpdata.h (revision 0)
>> >> @@ -0,0 +1,500 @@
>> >> +/**
>> >> + * Unpacking bitmap tables for RATE_FULL
>> >
>> > Are these the unpacked tables or the tables used to unpack?
>>
>> tables used to unpack
>
> Then write "bitmap unpacking tables for RATE_FULL", what you currently
> have is ambiguous (same in other places).

done