[FFmpeg-devel] [PATCH] RV40 Loop Filter

[Jethro Walters]

--- On Tue, 21/10/08, Michael Niedermayer <michaelni at gmx.at> wrote:

> From: Michael Niedermayer <michaelni at gmx.at>
> Subject: Re: [FFmpeg-devel] [PATCH] RV40 Loop Filter
> To: "FFmpeg development discussions and patches" <ffmpeg-devel at mplayerhq.hu>
> Date: Tuesday, 21 October, 2008, 6:56 PM
> On Tue, Oct 21, 2008 at 09:23:21AM +0300, Kostya wrote:
> > $subj
> > I've tested it and looks like filter is invoked properly now,
> > filtering workflow should be also correct, but there is some
> > non-bitexactness elsewhere, so result picture is still a bit
> > wrong.
> 
> do you want me to review this or wait until its bitexact?
> The reason why iam asking is that optimizing code that may
> not be
> exactly correct could turn out to be a waste of time (for
> both of
> us) ...
> 
> also some code maybe could be shared with h.264, but then
> maybe not
> ive not checked it too precissely

I've read this many times, and in this particular instance, is there no way of pinching the missing code from the H.264 decoder to accompany the existing code? If the 2 share traits and are common in some way, then as one is based on the standard of the other, it'd make sense, yesno?

Jethro Walters

P.S: I am in the process of changing my mail client.

--------------
Everyone knows that million-to-one chances that happen 9 times out of 10. How else would the handsome prince rescue his lovely princess from the evil dragon?

Send instant messages to your online friends http://uk.messenger.yahoo.com