[FFmpeg-devel] fix for >2GB files in flvdec.c

[Pascal Massimino]

  Hey Baptiste,

On Mon, Oct 20, 2008 at 10:08 AM, Baptiste Coudurier
<baptiste.coudurier at smartjog.com> wrote:
> Hi Pascal,
>
> Pascal Massimino wrote:
>> Hi everybody,
>>
>> patch against r15655 attached...
>>
>  > [...]
>>
>  > @@ -317,7 +318,7 @@
>>      if(size == 0)
>>          continue;
>>
>> -    next= size + url_ftell(s->pb);
>> +    next= url_ftell(s->pb) + size;
>
> Cosmetics ?

well, actually i'm not sure: will 'size' be promoted int64 if it's
first? or will the int64 in url_ftell() be demoted 'int' because of
the 'size' in front (yikes!)?
In doubt, i rely on left-to-right prevalence rule, but that's maybe just me...

>
>>      if (type == FLV_TAG_TYPE_AUDIO) {
>>          is_audio=1;
>> @@ -370,8 +371,8 @@
>>      // if not streamed and no duration from metadata then seek to end to find the duration from the timestamps
>>      if(!url_is_streamed(s->pb) && s->duration==AV_NOPTS_VALUE){
>>          int size;
>> -        const int pos= url_ftell(s->pb);
>> -        const int fsize= url_fsize(s->pb);
>> +        const int64_t pos= url_ftell(s->pb);
>> +        const int64_t fsize= url_fsize(s->pb);
>
> Pos seems to be uselessly redeclared here, this can be commited
> separately I guess.
>

indeed, the top 'pos' variable could be localized to block 306-369.

skal


> Im not maintainer, Michael will confirm.
>
> --
> Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
> Smartjog USA Inc.                                http://www.smartjog.com
> Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at mplayerhq.hu
> https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel
>