[FFmpeg-devel] [PATCH] ac3_parser type punning fix

[Michael Niedermayer]

On Mon, Oct 20, 2008 at 01:40:48AM -0700, Baptiste Coudurier wrote:
> On Oct 19, 2008, at 2:31 PM, Michael Niedermayer <michaelni at gmx.at>
[...]
> >
> >>
> >> Even at r15647 raw aac is still borken because the parser is still  
> >> broken.
> >
> > i dont know about the parser but raw aac is broken because
> > the aac decoder does
> >    if (avccontext->extradata_size <= 0 ||
> >        decode_audio_specific_config(ac, avccontext->extradata,  
> > avccontext->extradata_size))
> >        return -1;
> >
> > and nothing in raw.c nor in the parser sets extradata, nor is there a
> > AVCodecParser.split() that would cause extradata to be set.
> > Thats also why aac in mpeg-ts does not work ...
> 
> Well It is broken since some time now ... before aac decoder, and
> still broken with faad which supports both bitstream formats.
> 
> Btw, I guess these (aac, ac3) parsers should be updated when state64 
> will be added, needed by the dnxhd parser which I will commit soon (like 
> tomorrow).

yes, ive state64 for aac/ac3 support already locally, i just havnt
commited it as i found no case where it made a difference ...

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Breaking DRM is a little like attempting to break through a door even
though the window is wide open and the only thing in the house is a bunch
of things you dont want and which you would get tomorrow for free anyway
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20081020/30414c4a/attachment.pgp>