[FFmpeg-devel] Darwin gnu99

[Diego Biurrun]

On Sun, Oct 19, 2008 at 03:52:33PM -0500, Michael Witten wrote:
> 
> On 19 Oct 2008, at 5:27 AM, M?ns Rullg?rd wrote:
> 
> > Michael Witten <mfwitten at MIT.EDU> writes:
> >
> >> I had to make the following change to the configure script
> >> in order to build on Mac OS X 10.5:
> >>
> >> --- configure	(revision 15641)
> >> +++ configure	(working copy)
> >> @@ -1149,7 +1149,7 @@
> >>
> >> -check_cflags -std=c99
> >> +check_cflags -std=gnu99
> >
> > Rejected.  Please explain what breaks without any patches.
> 
> That language is a bit overly strong.

Come on, what do you want to hear instead of "Rejected."?  The change is
unacceptable as-is, it's just a plain statement of fact, nothing
personal.

> In any case, it would seem conrad was clever enough to pick
> up on the problem:
> 
> > $ svn log libswscale/yuv2rgb_altivec.c
> > ------------------------------------------------------------------------
> > r27805 | conrad | 2008-10-19 13:56:35 -0500 (Sun, 19 Oct 2008) | 1  
> > line
> >
> > Convert typeof keyword into __typeof__; this is a gcc extension and  
> > the former is not accepted in C99 without GNU extensions enabled  
> > (e.g. via -fasm).  This fixes compilation on PPC.
> 
> However, I wonder if I influenced this change, though I was
> admittedly quiet on the subject; it would be nice to include
> references to people that may have helped find the problem,
> because it makes people want to find and report more problems.

You did not influence this change.  It was impossible to guess
from your message what the problem was since you provided absolutely no
details.  In fact, the patch to fix the problem appeared before your
mail.

Bug reporting efforts are welcome, but they have to be detailed.
Otherwise they just negatively affect the signal to noise ratio on the
mailing list.  So next time please provide all the necessary details.

Diego