[FFmpeg-devel] [PATCH] fix libavdevice/audio.c build on FreeBSD
Sun Oct 19 15:20:00 CEST 2008
"Alexis Ballier" <alexis.ballier at gmail.com> writes:
>> Does any system with OSS audio not have sys/select.h? Until we find
>> one, I'd drop the #ifdef.
> well, according to:
> single unix spec v2 doesn't require sys/select.h
> but this one requires sys/select.h:
> Since you probably know better than me what ffmpeg requires, here is a
> patch without #ifery, leaving the decision up to you. I think ffmpeg
> requires IEEE 1003.1-2004 so we may assume sys/select.h is here and
> the #ifery seems to have been added for mingw compat where oss isn't
> supported, thus I believe it's indeed sane to drop the #ifdef.
Yes, we assume SUSv3 compatibility for the most part.
> Index: libavdevice/audio.c
> --- libavdevice/audio.c (revision 15646)
> +++ libavdevice/audio.c (working copy)
> @@ -34,6 +34,7 @@
> #include <fcntl.h>
> #include <sys/ioctl.h>
> #include <sys/time.h>
> +#include <sys/select.h>
> #include "libavutil/log.h"
> #include "libavcodec/avcodec.h"
Looks good, but I'm not the maintainer.
mans at mansr.com
More information about the ffmpeg-devel