[FFmpeg-devel] [PATCH 3/3] Include headers for optional libraries only when enabled.

[Michael Niedermayer]

On Thu, Oct 16, 2008 at 01:21:54PM +0200, Diego 'Flameeyes' Petten? wrote:
> Include the headers for libavfilter, libswscale and libpostproc when
> they are enabled (and thus linked in).
> 
> Without this change, Sun Studio will fail to link FFmpeg since two
> inline functions defined in avfilter.h will have undefined references
> to non-inline libavfilter functions.

well if this is the only solution (you did chek that there is no optimization
option that makes sun studio ommit unused functions ...)
then iam ok with it assuming it is documented in comments why these #if are
needed

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The misfortune of the wise is better than the prosperity of the fool.
-- Epicurus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20081018/b3c17127/attachment.pgp>