[FFmpeg-devel] [PATCH] Improve error-messaging with ffmpeg presets
Stefano Sabatini
stefano.sabatini-lala
Fri Oct 17 17:24:18 CEST 2008
On date Thursday 2008-10-16 23:21:58 -0200, Ramiro Polla encoded:
> >>> Index: ffmpeg.c
> >>> ===================================================================
> >>> --- ffmpeg.c (revision 15615)
> >>> +++ ffmpeg.c (working copy)
> >>> @@ -3690,7 +3690,7 @@
> >>> }
> >>>
> >>> if(!f){
> >>> - fprintf(stderr, "Preset file not found\n");
> >>> + fprintf(stderr, "File for preset '%s' not found\n", arg);
> >>> av_exit(1);
> >>> }
>
> > I think I'd prefer "Preset file '%s' not found\n"
This may be interpreted as "the preset file named '%s' has not been found",
but $arg is not always a filename, for example we could have the
max -> /usr/share/ffmpeg/libx264-max.ffpreset
conversion.
> Or maybe simply "Preset '%s' not found\n"
This is better, but still I have a slightly preference for
"File for preset '%s' not found" since it is more explicit.
Regards.
--
FFmpeg = Fast and Fostering Mean Programmable Evangelical Goblin
More information about the ffmpeg-devel
mailing list